#!/bin/bash ## usage: bash batch-2.sh.txt #[ -n "$1" ] && EDITOR="$1" #if [ -z "$EDITOR" ]; then # echo "Please provide parameter 1 (editor). Example: vi, joe" # exit 1 #fi function edit_at_line() { local f="$1" local l="$2" $EDITOR +$l "$f" } function ask_continue() { local line="" while [ "$line" != "y" -a "$line" != "n" ]; do echo -n "$1 (Y/n) " read line if [ -z "$line" ]; then line=y fi done if [ "$line" == "y" ]; then return 0 else return 1 fi } echo 'Welcome and thanks for helping with the cleanup!' echo '' echo 'This script will walk through a series of code-style issues in Civi'\''s PHP code.' echo 'For each issue, it will show a summary of the issue (ie how many files are' echo 'affected, how many lines of code are affected, and what detailed messages' echo 'are available about the issues.' echo '' echo 'The script will open the first file at the offending line so that you can fix' echo 'it. Please save, edit, close. The script will then repeat -- re-opening the text' echo 'editor at each offending line.' echo '' echo 'The script should generally open on the exact line with the problem; however,' echo 'if other changes were recently made to the file, then the line numbers may be' echo 'slightly off - if you don'\''t see a problem, then check the neighboring lines.' ask_continue 'Continue?' || exit echo '' echo 'What text editor would you prefer to use? [vi, emacs, joe]?' read EDITOR echo '===============================================================' echo 'Formatting issue: Drupal.Array.Array' echo 'Messages:Array ( [0] => A comma should follow the last multiline array item. Found: \"reset=1&jid={$eventQueue->job_id}&qid={$eventQueue->id}&h={$eventQueue->hash}\" [1] => A comma should follow the last multiline array item. Found: '\''Opt-out Requests'\'' [2] => A comma should follow the last multiline array item. Found: \" Successful\" [3] => A comma should follow the last multiline array item. Found: \"Successful\" [4] => A comma should follow the last multiline array item. Found: \"Opened\" [5] => A comma should follow the last multiline array item. Found: \"Clicked\" [6] => A comma should follow the last multiline array item. Found: '\''Is equal to Yes'\'' [7] => A comma should follow the last multiline array item. Found: \"Replied\" [8] => A comma should follow the last multiline array item. Found: \"Bounced\" [9] => A comma should follow the last multiline array item. Found: \"Unsubscribe Requests\" [10] => A comma should follow the last multiline array item. Found: \"Opt-out Requests\" [11] => A comma should follow the last multiline array item. Found: '\''subject'\'' [12] => A comma should follow the last multiline array item. Found: ) [13] => A comma should follow the last multiline array item. Found: '\''toEmail'\'' [14] => A comma should follow the last multiline array item. Found: '\''end_date'\'' [15] => A comma should follow the last multiline array item. Found: \"http://book.civicrm.org/user/advanced-configuration/email-system-configuration/\" [16] => A comma should follow the last multiline array item. Found: '\''Z'\'' [17] => A comma should follow the last multiline array item. Found: label ) ' echo 'Lines:Array ( [0] => tests/phpunit/WebTest/Mailing/MailingTest.php:233 [1] => tests/phpunit/WebTest/Mailing/MailingTest.php:436 [2] => tests/phpunit/WebTest/Mailing/MailingTest.php:463 [3] => tests/phpunit/WebTest/Mailing/MailingTest.php:467 [4] => tests/phpunit/WebTest/Mailing/MailingTest.php:475 [5] => tests/phpunit/WebTest/Mailing/MailingTest.php:483 [6] => tests/phpunit/WebTest/Mailing/MailingTest.php:491 [7] => tests/phpunit/WebTest/Mailing/MailingTest.php:500 [8] => tests/phpunit/WebTest/Mailing/MailingTest.php:504 [9] => tests/phpunit/WebTest/Mailing/MailingTest.php:512 [10] => tests/phpunit/WebTest/Mailing/MailingTest.php:520 [11] => tests/phpunit/WebTest/Mailing/MailingTest.php:524 [12] => tests/phpunit/WebTest/Mailing/MailingTest.php:532 [13] => tests/phpunit/WebTest/Mailing/MailingTest.php:536 [14] => CRM/Mailing/BAO/Mailing.php:740 [15] => CRM/Mailing/BAO/Mailing.php:937 [16] => CRM/Mailing/BAO/Mailing.php:1361 [17] => CRM/Mailing/BAO/Mailing.php:2073 [18] => CRM/Mailing/BAO/Mailing.php:2695 [19] => CRM/Mailing/BAO/Mailing.php:2842 [20] => CRM/Utils/PagerAToZ.php:93 [21] => CRM/Report/Form/Register.php:202 ) ' echo '' echo 'Total number of edits to perform: 22' if ask_continue 'Edit these files?'; then edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 233 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 436 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 463 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 467 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 475 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 483 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 491 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 500 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 504 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 512 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 520 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 524 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 532 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 536 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 740 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 937 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 1361 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 2073 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 2695 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 2842 edit_at_line 'CRM/Utils/PagerAToZ.php' 93 edit_at_line 'CRM/Report/Form/Register.php' 202 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Array.Array!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Formatting.MultiLineAssignment' echo 'Messages:Array ( [0] => Multi-line assignments must have the equal sign on the second line ) ' echo 'Lines:Array ( [0] => tests/phpunit/WebTest/Mailing/MailingTest.php:451 [1] => CRM/Mailing/BAO/Mailing.php:2188 [2] => CRM/Contact/BAO/Contact.php:306 [3] => CRM/Contact/BAO/Contact.php:1616 [4] => CRM/Contact/BAO/Contact.php:1617 [5] => CRM/Contact/BAO/Contact.php:1618 [6] => CRM/Contact/BAO/Contact.php:1619 [7] => CRM/Grant/Form/Grant.php:77 ) ' echo '' echo 'Total number of edits to perform: 8' if ask_continue 'Edit these files?'; then edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 451 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 2188 edit_at_line 'CRM/Contact/BAO/Contact.php' 306 edit_at_line 'CRM/Contact/BAO/Contact.php' 1616 edit_at_line 'CRM/Contact/BAO/Contact.php' 1617 edit_at_line 'CRM/Contact/BAO/Contact.php' 1618 edit_at_line 'CRM/Contact/BAO/Contact.php' 1619 edit_at_line 'CRM/Grant/Form/Grant.php' 77 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Formatting.MultiLineAssignment!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Array.Array.ArrayIndentation' echo 'Messages:Array ( [0] => Array indentation error, expected 8 spaces but found 10 [1] => Array indentation error, expected 6 spaces but found 8 [2] => Array indentation error, expected 6 spaces but found 10 ) ' echo 'Lines:Array ( [0] => tests/phpunit/WebTest/Mailing/MailingTest.php:454 [1] => tests/phpunit/WebTest/Mailing/MailingTest.php:457 [2] => tests/phpunit/WebTest/Mailing/MailingTest.php:459 [3] => tests/phpunit/WebTest/Mailing/MailingTest.php:469 [4] => tests/phpunit/WebTest/Mailing/MailingTest.php:471 [5] => tests/phpunit/WebTest/Mailing/MailingTest.php:477 [6] => tests/phpunit/WebTest/Mailing/MailingTest.php:479 [7] => tests/phpunit/WebTest/Mailing/MailingTest.php:485 [8] => tests/phpunit/WebTest/Mailing/MailingTest.php:487 [9] => tests/phpunit/WebTest/Mailing/MailingTest.php:494 [10] => tests/phpunit/WebTest/Mailing/MailingTest.php:496 [11] => tests/phpunit/WebTest/Mailing/MailingTest.php:506 [12] => tests/phpunit/WebTest/Mailing/MailingTest.php:508 [13] => tests/phpunit/WebTest/Mailing/MailingTest.php:514 [14] => tests/phpunit/WebTest/Mailing/MailingTest.php:516 [15] => tests/phpunit/WebTest/Mailing/MailingTest.php:526 [16] => tests/phpunit/WebTest/Mailing/MailingTest.php:528 [17] => tests/phpunit/WebTest/Mailing/MailingTest.php:538 [18] => CRM/Mailing/Selector/Event.php:432 [19] => CRM/Mailing/Selector/Event.php:433 [20] => CRM/Mailing/Selector/Event.php:437 [21] => CRM/Mailing/Selector/Event.php:438 [22] => CRM/Mailing/Selector/Event.php:440 [23] => CRM/Mailing/Selector/Event.php:441 [24] => CRM/Mailing/BAO/Mailing.php:1810 [25] => CRM/Mailing/BAO/Mailing.php:1880 [26] => CRM/Mailing/BAO/Mailing.php:1882 [27] => CRM/Mailing/BAO/Mailing.php:2128 [28] => CRM/Mailing/BAO/Mailing.php:2131 [29] => CRM/Mailing/BAO/Mailing.php:2133 [30] => CRM/Mailing/BAO/Mailing.php:2136 [31] => tests/phpunit/api/v3/ContributionTest.php:673 [32] => tests/phpunit/api/v3/ContributionTest.php:695 [33] => CRM/Contribute/Form/Contribution/Confirm.php:93 [34] => CRM/Contribute/Form/Contribution/Confirm.php:94 [35] => CRM/Contribute/Form/Contribution/Confirm.php:95 [36] => CRM/Contribute/Form/Contribution/Confirm.php:101 [37] => CRM/Contribute/Form/Contribution/Confirm.php:102 [38] => CRM/Contribute/Form/Contribution/Confirm.php:103 [39] => CRM/Contribute/Form/Contribution/Confirm.php:105 [40] => CRM/Contribute/Form/Contribution/Confirm.php:106 [41] => CRM/Contribute/Form/Contribution/Confirm.php:107 ) ' echo '' echo 'Total number of edits to perform: 42' if ask_continue 'Edit these files?'; then edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 454 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 457 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 459 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 469 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 471 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 477 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 479 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 485 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 487 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 494 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 496 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 506 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 508 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 514 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 516 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 526 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 528 edit_at_line 'tests/phpunit/WebTest/Mailing/MailingTest.php' 538 edit_at_line 'CRM/Mailing/Selector/Event.php' 432 edit_at_line 'CRM/Mailing/Selector/Event.php' 433 edit_at_line 'CRM/Mailing/Selector/Event.php' 437 edit_at_line 'CRM/Mailing/Selector/Event.php' 438 edit_at_line 'CRM/Mailing/Selector/Event.php' 440 edit_at_line 'CRM/Mailing/Selector/Event.php' 441 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 1810 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 1880 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 1882 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 2128 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 2131 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 2133 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 2136 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 673 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 695 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 93 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 94 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 95 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 101 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 102 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 103 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 105 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 106 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 107 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Array.Array.ArrayIndentation!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.ControlStructures.SwitchDeclaration.SpacingAfterBreak' echo 'Messages:Array ( [0] => Case breaking statements must be followed by a single blank line ) ' echo 'Lines:Array ( [0] => CRM/Mailing/Selector/Event.php:264 [1] => CRM/Mailing/Selector/Event.php:270 [2] => CRM/Mailing/Selector/Event.php:277 [3] => CRM/Mailing/Selector/Event.php:284 [4] => CRM/Mailing/Selector/Event.php:291 [5] => CRM/Mailing/Selector/Event.php:298 [6] => CRM/Mailing/Selector/Event.php:305 [7] => CRM/Mailing/Selector/Event.php:312 [8] => CRM/Mailing/Selector/Event.php:320 [9] => CRM/Mailing/Selector/Event.php:351 [10] => CRM/Mailing/Selector/Event.php:357 [11] => CRM/Mailing/Selector/Event.php:363 [12] => CRM/Mailing/Selector/Event.php:369 [13] => CRM/Mailing/Selector/Event.php:375 [14] => CRM/Mailing/Selector/Event.php:381 [15] => CRM/Mailing/Selector/Event.php:387 [16] => CRM/Mailing/Selector/Event.php:393 [17] => CRM/Mailing/Selector/Event.php:399 [18] => CRM/Contact/BAO/Contact.php:526 [19] => CRM/Contact/BAO/Contact.php:2546 ) ' echo '' echo 'Total number of edits to perform: 20' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Mailing/Selector/Event.php' 264 edit_at_line 'CRM/Mailing/Selector/Event.php' 270 edit_at_line 'CRM/Mailing/Selector/Event.php' 277 edit_at_line 'CRM/Mailing/Selector/Event.php' 284 edit_at_line 'CRM/Mailing/Selector/Event.php' 291 edit_at_line 'CRM/Mailing/Selector/Event.php' 298 edit_at_line 'CRM/Mailing/Selector/Event.php' 305 edit_at_line 'CRM/Mailing/Selector/Event.php' 312 edit_at_line 'CRM/Mailing/Selector/Event.php' 320 edit_at_line 'CRM/Mailing/Selector/Event.php' 351 edit_at_line 'CRM/Mailing/Selector/Event.php' 357 edit_at_line 'CRM/Mailing/Selector/Event.php' 363 edit_at_line 'CRM/Mailing/Selector/Event.php' 369 edit_at_line 'CRM/Mailing/Selector/Event.php' 375 edit_at_line 'CRM/Mailing/Selector/Event.php' 381 edit_at_line 'CRM/Mailing/Selector/Event.php' 387 edit_at_line 'CRM/Mailing/Selector/Event.php' 393 edit_at_line 'CRM/Mailing/Selector/Event.php' 399 edit_at_line 'CRM/Contact/BAO/Contact.php' 526 edit_at_line 'CRM/Contact/BAO/Contact.php' 2546 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.ControlStructures.SwitchDeclaration.SpacingAfterBreak!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.WhiteSpace.ScopeIndent.IncorrectExact' echo 'Messages:Array ( [0] => Line indented incorrectly; expected 6 spaces, found 8 ) ' echo 'Lines:Array ( [0] => CRM/Mailing/Selector/Event.php:354 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Mailing/Selector/Event.php' 354 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.WhiteSpace.ScopeIndent.IncorrectExact!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.InvalidNoReturn' echo 'Messages:Array ( [0] => @return doc comment specified, but function has no return statement ) ' echo 'Lines:Array ( [0] => CRM/Mailing/Selector/Event.php:416 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Mailing/Selector/Event.php' 416 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.InvalidNoReturn!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Formatting.SpaceInlineIf.SpacingBefore' echo 'Messages:Array ( [0] => Expected 1 space before \"?\"; newline found [1] => Expected 1 space before \":\"; newline found ) ' echo 'Lines:Array ( [0] => CRM/Mailing/Selector/Event.php:432 [1] => CRM/Mailing/Selector/Event.php:433 [2] => CRM/Mailing/Selector/Event.php:437 [3] => CRM/Mailing/Selector/Event.php:438 [4] => CRM/Mailing/Selector/Event.php:440 [5] => CRM/Mailing/Selector/Event.php:441 ) ' echo '' echo 'Total number of edits to perform: 6' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Mailing/Selector/Event.php' 432 edit_at_line 'CRM/Mailing/Selector/Event.php' 433 edit_at_line 'CRM/Mailing/Selector/Event.php' 437 edit_at_line 'CRM/Mailing/Selector/Event.php' 438 edit_at_line 'CRM/Mailing/Selector/Event.php' 440 edit_at_line 'CRM/Mailing/Selector/Event.php' 441 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Formatting.SpaceInlineIf.SpacingBefore!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.Scope.MethodScope.Missing' echo 'Messages:Array ( [0] => Visibility must be declared on method \"getRecipients\" [1] => Visibility must be declared on method \"importableFields\" [2] => Visibility must be declared on method \"createProfileContact\" [3] => Visibility must be declared on method \"formatProfileContactParams\" [4] => Visibility must be declared on method \"_getFinancialTrxnAmount\" [5] => Visibility must be declared on method \"_getFinancialItemAmount\" [6] => Visibility must be declared on method \"processContribution\" [7] => Visibility must be declared on method \"__construct\" ) ' echo 'Lines:Array ( [0] => CRM/Mailing/BAO/Mailing.php:126 [1] => CRM/Contact/BAO/Contact.php:1176 [2] => CRM/Contact/BAO/Contact.php:1829 [3] => CRM/Contact/BAO/Contact.php:1930 [4] => tests/phpunit/api/v3/ContributionTest.php:1624 [5] => tests/phpunit/api/v3/ContributionTest.php:1641 [6] => CRM/Contribute/Form/Contribution/Confirm.php:1229 [7] => CRM/Contact/StateMachine/Search.php:47 ) ' echo '' echo 'Total number of edits to perform: 8' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Mailing/BAO/Mailing.php' 126 edit_at_line 'CRM/Contact/BAO/Contact.php' 1176 edit_at_line 'CRM/Contact/BAO/Contact.php' 1829 edit_at_line 'CRM/Contact/BAO/Contact.php' 1930 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 1624 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 1641 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 1229 edit_at_line 'CRM/Contact/StateMachine/Search.php' 47 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.Scope.MethodScope.Missing!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.DocComment.WrongEnd' echo 'Messages:Array ( [0] => Wrong function doc comment end; expected \"*/\", found \"**/\" ) ' echo 'Lines:Array ( [0] => CRM/Mailing/BAO/Mailing.php:630 [1] => CRM/Mailing/BAO/Mailing.php:728 [2] => CRM/Mailing/BAO/Mailing.php:777 [3] => CRM/Mailing/BAO/Mailing.php:845 [4] => CRM/Mailing/BAO/Mailing.php:879 ) ' echo '' echo 'Total number of edits to perform: 5' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Mailing/BAO/Mailing.php' 630 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 728 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 777 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 845 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 879 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.DocComment.WrongEnd!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Semantics.FunctionAlias.FunctionAlias' echo 'Messages:Array ( [0] => join() is a function name alias, use implode() instead ) ' echo 'Lines:Array ( [0] => CRM/Mailing/BAO/Mailing.php:651 [1] => CRM/Mailing/BAO/Mailing.php:795 [2] => CRM/Mailing/BAO/Mailing.php:811 [3] => CRM/Mailing/BAO/Mailing.php:824 [4] => CRM/Mailing/BAO/Mailing.php:1306 [5] => CRM/Mailing/BAO/Mailing.php:1317 [6] => CRM/Mailing/BAO/Mailing.php:1338 ) ' echo '' echo 'Total number of edits to perform: 7' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Mailing/BAO/Mailing.php' 651 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 795 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 811 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 824 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 1306 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 1317 edit_at_line 'CRM/Mailing/BAO/Mailing.php' 1338 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Semantics.FunctionAlias.FunctionAlias!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.MissingParamName' echo 'Messages:Array ( [0] => Missing parameter name ) ' echo 'Lines:Array ( [0] => CRM/Mailing/BAO/Mailing.php:973 [1] => CRM/Contact/BAO/Contact.php:1821 ) ' echo '' echo 'Total number of edits to perform: 2' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Mailing/BAO/Mailing.php' 973 edit_at_line 'CRM/Contact/BAO/Contact.php' 1821 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.MissingParamName!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.PHP.NonExecutableCode.ReturnNotRequired' echo 'Messages:Array ( [0] => Empty return statement not required here ) ' echo 'Lines:Array ( [0] => CRM/Mailing/BAO/Mailing.php:2309 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Mailing/BAO/Mailing.php' 2309 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.PHP.NonExecutableCode.ReturnNotRequired!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.InvalidReturn' echo 'Messages:Array ( [0] => Expected \"bool\" but found \"boolean\" for function return type [1] => Expected \"string\" but found \"String\" for function return type [2] => Expected \"array\" but found \"Array\" for function return type [3] => Expected \"array|bool\" but found \"Array|bool\" for function return type ) ' echo 'Lines:Array ( [0] => CRM/Mailing/BAO/Mailing.php:2340 [1] => CRM/Contact/BAO/Contact.php:760 [2] => CRM/Contact/BAO/Contact.php:893 [3] => CRM/Contact/BAO/Contact.php:915 [4] => CRM/Contact/BAO/Contact.php:957 [5] => CRM/Contact/BAO/Contact.php:991 [6] => CRM/Contact/BAO/Contact.php:3287 ) ' echo '' echo 'Total number of edits to perform: 7' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Mailing/BAO/Mailing.php' 2340 edit_at_line 'CRM/Contact/BAO/Contact.php' 760 edit_at_line 'CRM/Contact/BAO/Contact.php' 893 edit_at_line 'CRM/Contact/BAO/Contact.php' 915 edit_at_line 'CRM/Contact/BAO/Contact.php' 957 edit_at_line 'CRM/Contact/BAO/Contact.php' 991 edit_at_line 'CRM/Contact/BAO/Contact.php' 3287 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.InvalidReturn!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.InvalidReturnNotVoid' echo 'Messages:Array ( [0] => Function return type is not void, but function is returning void here ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Contact.php:117 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Contact.php' 117 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.InvalidReturnNotVoid!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines' echo 'Messages:Array ( [0] => Functions must not contain multiple empty lines in a row; found 2 empty lines ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Contact.php:407 [1] => CRM/Contact/BAO/Contact.php:810 [2] => CRM/Contact/BAO/Contact.php:1452 [3] => CRM/Contact/BAO/Contact.php:2313 [4] => CRM/Contribute/Form/Contribution/Confirm.php:1415 [5] => CRM/Contribute/Form/Contribution/Confirm.php:1504 ) ' echo '' echo 'Total number of edits to perform: 6' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Contact.php' 407 edit_at_line 'CRM/Contact/BAO/Contact.php' 810 edit_at_line 'CRM/Contact/BAO/Contact.php' 1452 edit_at_line 'CRM/Contact/BAO/Contact.php' 2313 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 1415 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 1504 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Formatting.SpaceInlineIf.SpacingAfter' echo 'Messages:Array ( [0] => Expected 1 space after \"?\"; newline found [1] => Expected 1 space after \":\"; newline found ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Contact.php:484 [1] => CRM/Contact/BAO/Contact.php:487 [2] => CRM/Contribute/Form/Contribution/Confirm.php:93 [3] => CRM/Contribute/Form/Contribution/Confirm.php:94 [4] => CRM/Contribute/Form/Contribution/Confirm.php:101 [5] => CRM/Contribute/Form/Contribution/Confirm.php:102 [6] => CRM/Contribute/Form/Contribution/Confirm.php:105 [7] => CRM/Contribute/Form/Contribution/Confirm.php:106 ) ' echo '' echo 'Total number of edits to perform: 8' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Contact.php' 484 edit_at_line 'CRM/Contact/BAO/Contact.php' 487 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 93 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 94 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 101 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 102 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 105 edit_at_line 'CRM/Contribute/Form/Contribution/Confirm.php' 106 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Formatting.SpaceInlineIf.SpacingAfter!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.ControlStructures.InlineControlStructure.NotAllowed' echo 'Messages:Array ( [0] => Inline control structures are not allowed ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Contact.php:1144 [1] => CRM/Contact/BAO/Contact.php:3262 ) ' echo '' echo 'Total number of edits to perform: 2' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Contact.php' 1144 edit_at_line 'CRM/Contact/BAO/Contact.php' 3262 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.ControlStructures.InlineControlStructure.NotAllowed!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.$InReturnType' echo 'Messages:Array ( [0] => @return data type must not contain \"$\" ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Contact.php:1606 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Contact.php' 1606 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.$InReturnType!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.Commenting.DocCommentAlignment.SpaceAfterStar' echo 'Messages:Array ( [0] => Expected 1 space after asterisk; 3 found ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Contact.php:3283 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Contact.php' 3283 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.Commenting.DocCommentAlignment.SpaceAfterStar!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.SeePunctuation' echo 'Messages:Array ( [0] => Trailing punctuation for @see references is not allowed. ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Contact.php:3283 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Contact.php' 3283 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.SeePunctuation!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.WrongStyle' echo 'Messages:Array ( [0] => You must use \"/**\" style comments for a function comment ) ' echo 'Lines:Array ( [0] => tests/phpunit/api/v3/ContributionTest.php:254 [1] => tests/phpunit/api/v3/ContributionTest.php:269 [2] => tests/phpunit/api/v3/ContributionTest.php:353 [3] => tests/phpunit/api/v3/ContributionTest.php:729 [4] => tests/phpunit/api/v3/ContributionTest.php:864 [5] => tests/phpunit/api/v3/ContributionTest.php:908 [6] => tests/phpunit/api/v3/ContributionTest.php:947 [7] => tests/phpunit/api/v3/ContributionTest.php:975 [8] => tests/phpunit/api/v3/ContributionTest.php:1000 [9] => tests/phpunit/api/v3/ContributionTest.php:1025 [10] => tests/phpunit/api/v3/ContributionTest.php:1047 [11] => tests/phpunit/api/v3/ContributionTest.php:1072 [12] => tests/phpunit/api/v3/ContributionTest.php:1107 [13] => tests/phpunit/api/v3/ContributionTest.php:1175 ) ' echo '' echo 'Total number of edits to perform: 14' if ask_continue 'Edit these files?'; then edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 254 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 269 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 353 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 729 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 864 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 908 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 947 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 975 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 1000 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 1025 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 1047 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 1072 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 1107 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 1175 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.WrongStyle!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.WhiteSpace.Comma.NoSpace' echo 'Messages:Array ( [0] => Expected one space after the comma, 0 found ) ' echo 'Lines:Array ( [0] => tests/phpunit/api/v3/ContributionTest.php:466 [1] => tests/phpunit/api/v3/ContributionTest.php:467 [2] => tests/phpunit/api/v3/ContributionTest.php:468 [3] => tests/phpunit/api/v3/ContributionTest.php:470 [4] => tests/phpunit/api/v3/ContributionTest.php:1157 ) ' echo '' echo 'Total number of edits to perform: 6' if ask_continue 'Edit these files?'; then edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 466 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 467 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 468 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 468 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 470 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 1157 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.WhiteSpace.Comma.NoSpace!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Array.Array.ArrayClosingIndentation' echo 'Messages:Array ( [0] => Array closing indentation error, expected 4 spaces but found 6 ) ' echo 'Lines:Array ( [0] => tests/phpunit/api/v3/ContributionTest.php:674 [1] => tests/phpunit/api/v3/ContributionTest.php:696 ) ' echo '' echo 'Total number of edits to perform: 2' if ask_continue 'Edit these files?'; then edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 674 edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 696 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Array.Array.ArrayClosingIndentation!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace' echo 'Messages:Array ( [0] => There should be no white space before a closing \")\" ) ' echo 'Lines:Array ( [0] => tests/phpunit/api/v3/ContributionTest.php:1157 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'tests/phpunit/api/v3/ContributionTest.php' 1157 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.WhiteSpace.CloseBracketSpacing.ClosingWhitespace!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.WhiteSpace.OpenBracketSpacing.OpeningWhitespace' echo 'Messages:Array ( [0] => There should be no white space after an opening \"{\" ) ' echo 'Lines:Array ( [0] => CRM/Utils/Cache/APCcache.php:113 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Utils/Cache/APCcache.php' 113 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.WhiteSpace.OpenBracketSpacing.OpeningWhitespace!' echo '' echo 'Yay!' echo '' fi