#!/bin/bash ## usage: bash batch-10.sh.txt #[ -n "$1" ] && EDITOR="$1" #if [ -z "$EDITOR" ]; then # echo "Please provide parameter 1 (editor). Example: vi, joe" # exit 1 #fi function edit_at_line() { local f="$1" local l="$2" $EDITOR +$l "$f" } function ask_continue() { local line="" while [ "$line" != "y" -a "$line" != "n" ]; do echo -n "$1 (Y/n) " read line if [ -z "$line" ]; then line=y fi done if [ "$line" == "y" ]; then return 0 else return 1 fi } echo 'Welcome and thanks for helping with the cleanup!' echo '' echo 'This script will walk through a series of code-style issues in Civi'\''s PHP code.' echo 'For each issue, it will show a summary of the issue (ie how many files are' echo 'affected, how many lines of code are affected, and what detailed messages' echo 'are available about the issues.' echo '' echo 'The script will open the first file at the offending line so that you can fix' echo 'it. Please save, edit, close. The script will then repeat -- re-opening the text' echo 'editor at each offending line.' echo '' echo 'The script should generally open on the exact line with the problem; however,' echo 'if other changes were recently made to the file, then the line numbers may be' echo 'slightly off - if you don'\''t see a problem, then check the neighboring lines.' ask_continue 'Continue?' || exit echo '' echo 'What text editor would you prefer to use? [vi, emacs, joe]?' read EDITOR echo '===============================================================' echo 'Formatting issue: Drupal.Array.Array' echo 'Messages:Array ( [0] => A comma should follow the last multiline array item. Found: ) [1] => A comma should follow the last multiline array item. Found: $house [2] => A comma should follow the last multiline array item. Found: '\''%count relationships were not created because the contact is not of the right type for this relationship'\'' [3] => A comma should follow the last multiline array item. Found: '\''Relationships created.'\'' [4] => A comma should follow the last multiline array item. Found: \"showOptionSelect();\" [5] => A comma should follow the last multiline array item. Found: 5 [6] => A comma should follow the last multiline array item. Found: $max_value [7] => A comma should follow the last multiline array item. Found: '\''notes'\'' [8] => A comma should follow the last multiline array item. Found: '\''note_subject'\'' [9] => A comma should follow the last multiline array item. Found: membership_block_id [10] => A comma should follow the last multiline array item. Found: '\''Integer'\'' [11] => A comma should follow the last multiline array item. Found: $status [12] => A comma should follow the last multiline array item. Found: '\''case_status'\'' [13] => A comma should follow the last multiline array item. Found: ] [14] => A comma should follow the last multiline array item. Found: '\''administer CiviCase'\'' [15] => A comma should follow the last multiline array item. Found: '\''en_AU'\'' [16] => A comma should follow the last multiline array item. Found: 1 [17] => A comma should follow the last multiline array item. Found: '\''http://wiki.civicrm.org/confluence/display/CRMDOC/Fixing+Transactions+Missing+a+Payment+Instrument+-+4.4.3+Upgrades'\'' [18] => A comma should follow the last multiline array item. Found: '\''to'\'' ) ' echo 'Lines:Array ( [0] => CRM/Contact/Form/Task/AddToHousehold.php:65 [1] => CRM/Contact/Form/Task/AddToHousehold.php:167 [2] => CRM/Contact/Form/Task/AddToHousehold.php:168 [3] => CRM/Contact/Form/Task/AddToHousehold.php:175 [4] => CRM/Contact/Form/Task/AddToHousehold.php:181 [5] => CRM/Contact/Form/Task/AddToHousehold.php:187 [6] => CRM/Custom/Form/Field.php:345 [7] => CRM/Custom/Form/Field.php:354 [8] => CRM/Custom/Form/Field.php:927 [9] => CRM/Price/BAO/PriceField.php:312 [10] => CRM/Price/BAO/PriceField.php:503 [11] => CRM/Price/BAO/PriceField.php:625 [12] => CRM/Core/BAO/Mapping.php:366 [13] => CRM/Core/BAO/Mapping.php:391 [14] => CRM/Upgrade/Incremental/php/FourTwo.php:436 [15] => CRM/Upgrade/Incremental/php/FourTwo.php:658 [16] => CRM/Upgrade/Incremental/php/FourTwo.php:970 [17] => CRM/Core/Page/Basic.php:303 [18] => CRM/Core/Payment.php:306 [19] => CRM/Core/Payment.php:321 [20] => CRM/Core/Payment.php:360 [21] => CRM/Core/Payment.php:381 [22] => CRM/Core/Payment/PayPalProIPN.php:230 [23] => CRM/Core/Payment/PayPalProIPN.php:545 [24] => CRM/Core/Payment/PayPalProIPN.php:560 [25] => CRM/Core/Payment/PayPalProIPN.php:561 [26] => CRM/Upgrade/Incremental/php/ThreeTwo.php:56 [27] => CRM/Upgrade/Incremental/php/ThreeTwo.php:117 [28] => tests/phpunit/WebTest/Event/AddParticipationTest.php:362 [29] => tests/phpunit/WebTest/Event/AddParticipationTest.php:367 [30] => tests/phpunit/WebTest/Event/AddParticipationTest.php:384 [31] => tests/phpunit/WebTest/Event/AddParticipationTest.php:389 [32] => tests/phpunit/WebTest/Event/AddParticipationTest.php:394 [33] => CRM/Price/Form/Set.php:77 [34] => CRM/Price/Form/Set.php:305 [35] => CRM/Upgrade/Incremental/php/FourFour.php:107 [36] => CRM/Utils/Date.php:1621 [37] => CRM/Contribute/BAO/Widget.php:130 [38] => CRM/Contribute/BAO/Widget.php:144 [39] => CRM/Contribute/BAO/Widget.php:151 [40] => CRM/Contribute/BAO/Widget.php:158 [41] => CRM/Contribute/BAO/Widget.php:178 ) ' echo '' echo 'Total number of edits to perform: 42' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/Form/Task/AddToHousehold.php' 65 edit_at_line 'CRM/Contact/Form/Task/AddToHousehold.php' 167 edit_at_line 'CRM/Contact/Form/Task/AddToHousehold.php' 168 edit_at_line 'CRM/Contact/Form/Task/AddToHousehold.php' 175 edit_at_line 'CRM/Contact/Form/Task/AddToHousehold.php' 181 edit_at_line 'CRM/Contact/Form/Task/AddToHousehold.php' 187 edit_at_line 'CRM/Custom/Form/Field.php' 345 edit_at_line 'CRM/Custom/Form/Field.php' 354 edit_at_line 'CRM/Custom/Form/Field.php' 927 edit_at_line 'CRM/Price/BAO/PriceField.php' 312 edit_at_line 'CRM/Price/BAO/PriceField.php' 503 edit_at_line 'CRM/Price/BAO/PriceField.php' 625 edit_at_line 'CRM/Core/BAO/Mapping.php' 366 edit_at_line 'CRM/Core/BAO/Mapping.php' 391 edit_at_line 'CRM/Upgrade/Incremental/php/FourTwo.php' 436 edit_at_line 'CRM/Upgrade/Incremental/php/FourTwo.php' 658 edit_at_line 'CRM/Upgrade/Incremental/php/FourTwo.php' 970 edit_at_line 'CRM/Core/Page/Basic.php' 303 edit_at_line 'CRM/Core/Payment.php' 306 edit_at_line 'CRM/Core/Payment.php' 321 edit_at_line 'CRM/Core/Payment.php' 360 edit_at_line 'CRM/Core/Payment.php' 381 edit_at_line 'CRM/Core/Payment/PayPalProIPN.php' 230 edit_at_line 'CRM/Core/Payment/PayPalProIPN.php' 545 edit_at_line 'CRM/Core/Payment/PayPalProIPN.php' 560 edit_at_line 'CRM/Core/Payment/PayPalProIPN.php' 561 edit_at_line 'CRM/Upgrade/Incremental/php/ThreeTwo.php' 56 edit_at_line 'CRM/Upgrade/Incremental/php/ThreeTwo.php' 117 edit_at_line 'tests/phpunit/WebTest/Event/AddParticipationTest.php' 362 edit_at_line 'tests/phpunit/WebTest/Event/AddParticipationTest.php' 367 edit_at_line 'tests/phpunit/WebTest/Event/AddParticipationTest.php' 384 edit_at_line 'tests/phpunit/WebTest/Event/AddParticipationTest.php' 389 edit_at_line 'tests/phpunit/WebTest/Event/AddParticipationTest.php' 394 edit_at_line 'CRM/Price/Form/Set.php' 77 edit_at_line 'CRM/Price/Form/Set.php' 305 edit_at_line 'CRM/Upgrade/Incremental/php/FourFour.php' 107 edit_at_line 'CRM/Utils/Date.php' 1621 edit_at_line 'CRM/Contribute/BAO/Widget.php' 130 edit_at_line 'CRM/Contribute/BAO/Widget.php' 144 edit_at_line 'CRM/Contribute/BAO/Widget.php' 151 edit_at_line 'CRM/Contribute/BAO/Widget.php' 158 edit_at_line 'CRM/Contribute/BAO/Widget.php' 178 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Array.Array!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Formatting.SpaceInlineIf.SpacingAfter' echo 'Messages:Array ( [0] => Expected 1 space after \"?\"; newline found ) ' echo 'Lines:Array ( [0] => CRM/Contact/Form/Task/AddToHousehold.php:288 [1] => CRM/Event/Form/Registration.php:882 ) ' echo '' echo 'Total number of edits to perform: 2' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/Form/Task/AddToHousehold.php' 288 edit_at_line 'CRM/Event/Form/Registration.php' 882 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Formatting.SpaceInlineIf.SpacingAfter!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.Scope.MethodScope.Missing' echo 'Messages:Array ( [0] => Visibility must be declared on method \"languageNegotiationURL\" [1] => Visibility must be declared on method \"__construct\" [2] => Visibility must be declared on method \"getBAOName\" [3] => Visibility must be declared on method \"links\" [4] => Visibility must be declared on method \"editForm\" [5] => Visibility must be declared on method \"editName\" [6] => Visibility must be declared on method \"userContext\" [7] => Visibility must be declared on method \"doDirectPayment\" [8] => Visibility must be declared on method \"checkConfig\" [9] => Visibility must be declared on method \"handleException\" [10] => Visibility must be declared on method \"add\" ) ' echo 'Lines:Array ( [0] => CRM/Utils/System/Base.php:145 [1] => CRM/Contact/Import/Parser/Contact.php:105 [2] => CRM/Core/Page/Basic.php:49 [3] => CRM/Core/Page/Basic.php:57 [4] => CRM/Core/Page/Basic.php:64 [5] => CRM/Core/Page/Basic.php:71 [6] => CRM/Core/Page/Basic.php:81 [7] => CRM/Core/Payment.php:411 [8] => CRM/Core/Payment.php:445 [9] => CRM/Contribute/Selector/Search.php:166 [10] => CRM/Core/LegacyErrorHandler.php:8 [11] => CRM/Utils/Recent.php:97 ) ' echo '' echo 'Total number of edits to perform: 12' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Utils/System/Base.php' 145 edit_at_line 'CRM/Contact/Import/Parser/Contact.php' 105 edit_at_line 'CRM/Core/Page/Basic.php' 49 edit_at_line 'CRM/Core/Page/Basic.php' 57 edit_at_line 'CRM/Core/Page/Basic.php' 64 edit_at_line 'CRM/Core/Page/Basic.php' 71 edit_at_line 'CRM/Core/Page/Basic.php' 81 edit_at_line 'CRM/Core/Payment.php' 411 edit_at_line 'CRM/Core/Payment.php' 445 edit_at_line 'CRM/Contribute/Selector/Search.php' 166 edit_at_line 'CRM/Core/LegacyErrorHandler.php' 8 edit_at_line 'CRM/Utils/Recent.php' 97 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.Scope.MethodScope.Missing!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.InvalidNoReturn' echo 'Messages:Array ( [0] => @return doc comment specified, but function has no return statement ) ' echo 'Lines:Array ( [0] => CRM/Utils/System/Base.php:180 [1] => CRM/Utils/System/Base.php:314 [2] => CRM/Utils/System/Base.php:323 [3] => CRM/Core/BAO/LabelFormat.php:277 [4] => CRM/Core/Permission/Base.php:159 [5] => CRM/Core/Permission/Base.php:187 [6] => CRM/Core/Permission/Base.php:200 [7] => CRM/PCP/BAO/PCP.php:353 [8] => CRM/PCP/BAO/PCP.php:585 [9] => CRM/Upgrade/Incremental/php/FourFour.php:364 [10] => CRM/Utils/System/Soap.php:202 ) ' echo '' echo 'Total number of edits to perform: 11' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Utils/System/Base.php' 180 edit_at_line 'CRM/Utils/System/Base.php' 314 edit_at_line 'CRM/Utils/System/Base.php' 323 edit_at_line 'CRM/Core/BAO/LabelFormat.php' 277 edit_at_line 'CRM/Core/Permission/Base.php' 159 edit_at_line 'CRM/Core/Permission/Base.php' 187 edit_at_line 'CRM/Core/Permission/Base.php' 200 edit_at_line 'CRM/PCP/BAO/PCP.php' 353 edit_at_line 'CRM/PCP/BAO/PCP.php' 585 edit_at_line 'CRM/Upgrade/Incremental/php/FourFour.php' 364 edit_at_line 'CRM/Utils/System/Soap.php' 202 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.InvalidNoReturn!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.ReturnCommentIndentation' echo 'Messages:Array ( [0] => Return comment indentation must be 3 spaces, found 1 spaces ) ' echo 'Lines:Array ( [0] => CRM/Utils/System/Base.php:221 [1] => CRM/Utils/System/Base.php:222 [2] => CRM/Utils/System/Base.php:223 [3] => CRM/Utils/Array.php:747 [4] => CRM/Utils/Array.php:748 [5] => CRM/Utils/Array.php:751 [6] => CRM/Utils/Array.php:752 [7] => CRM/Utils/Array.php:753 [8] => CRM/Utils/Array.php:758 [9] => api/v3/ActionSchedule.php:56 ) ' echo '' echo 'Total number of edits to perform: 10' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Utils/System/Base.php' 221 edit_at_line 'CRM/Utils/System/Base.php' 222 edit_at_line 'CRM/Utils/System/Base.php' 223 edit_at_line 'CRM/Utils/Array.php' 747 edit_at_line 'CRM/Utils/Array.php' 748 edit_at_line 'CRM/Utils/Array.php' 751 edit_at_line 'CRM/Utils/Array.php' 752 edit_at_line 'CRM/Utils/Array.php' 753 edit_at_line 'CRM/Utils/Array.php' 758 edit_at_line 'api/v3/ActionSchedule.php' 56 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.ReturnCommentIndentation!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Formatting.MultiLineAssignment' echo 'Messages:Array ( [0] => Multi-line assignments must have the equal sign on the second line ) ' echo 'Lines:Array ( [0] => CRM/Contact/Import/Parser/Contact.php:151 [1] => CRM/Core/BAO/Mapping.php:475 [2] => CRM/Upgrade/Incremental/php/FourTwo.php:724 [3] => CRM/Upgrade/Incremental/php/FourTwo.php:728 [4] => CRM/Event/Form/Registration.php:396 [5] => CRM/Event/Form/Registration.php:1293 [6] => CRM/Event/Form/Registration.php:1311 [7] => CRM/Event/Form/Registration.php:1315 [8] => CRM/Event/Form/Registration.php:1319 [9] => CRM/Contribute/Selector/Search.php:454 [10] => CRM/Contribute/Selector/Search.php:466 [11] => CRM/Contribute/Selector/Search.php:514 [12] => CRM/Contribute/Selector/Search.php:531 [13] => CRM/Core/BAO/FinancialTrxn.php:70 [14] => CRM/Core/BAO/FinancialTrxn.php:387 [15] => CRM/Core/BAO/FinancialTrxn.php:396 [16] => CRM/Report/Form/Contact/CurrentEmployer.php:280 ) ' echo '' echo 'Total number of edits to perform: 17' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/Import/Parser/Contact.php' 151 edit_at_line 'CRM/Core/BAO/Mapping.php' 475 edit_at_line 'CRM/Upgrade/Incremental/php/FourTwo.php' 724 edit_at_line 'CRM/Upgrade/Incremental/php/FourTwo.php' 728 edit_at_line 'CRM/Event/Form/Registration.php' 396 edit_at_line 'CRM/Event/Form/Registration.php' 1293 edit_at_line 'CRM/Event/Form/Registration.php' 1311 edit_at_line 'CRM/Event/Form/Registration.php' 1315 edit_at_line 'CRM/Event/Form/Registration.php' 1319 edit_at_line 'CRM/Contribute/Selector/Search.php' 454 edit_at_line 'CRM/Contribute/Selector/Search.php' 466 edit_at_line 'CRM/Contribute/Selector/Search.php' 514 edit_at_line 'CRM/Contribute/Selector/Search.php' 531 edit_at_line 'CRM/Core/BAO/FinancialTrxn.php' 70 edit_at_line 'CRM/Core/BAO/FinancialTrxn.php' 387 edit_at_line 'CRM/Core/BAO/FinancialTrxn.php' 396 edit_at_line 'CRM/Report/Form/Contact/CurrentEmployer.php' 280 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Formatting.MultiLineAssignment!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.InvalidReturn' echo 'Messages:Array ( [0] => Expected \"bool\" but found \"boolean\" for function return type [1] => Expected \"void|bool\" but found \"void|boolean\" for function return type [2] => Expected \"bool\" but found \"Boolean\" for function return type [3] => Expected \"string\" but found \"String\" for function return type [4] => Expected \"object\" but found \"stdClass\" for function return type ) ' echo 'Lines:Array ( [0] => CRM/Contact/Import/Parser/Contact.php:253 [1] => CRM/Contact/Import/Parser/Contact.php:265 [2] => CRM/Contact/Import/Parser/Contact.php:278 [3] => CRM/Contact/Import/Parser/Contact.php:452 [4] => CRM/Price/BAO/PriceField.php:639 [5] => CRM/Core/BAO/Mapping.php:71 [6] => CRM/Core/BAO/Mapping.php:207 [7] => CRM/Utils/Array.php:443 [8] => CRM/Core/Permission/Base.php:159 [9] => CRM/Core/Permission/Base.php:173 [10] => CRM/Core/Payment.php:592 [11] => CRM/Core/Payment/PayPalProIPN.php:166 [12] => CRM/Core/Payment/PayPalProIPN.php:392 [13] => CRM/PCP/BAO/PCP.php:781 [14] => CRM/PCP/BAO/PCP.php:800 [15] => CRM/PCP/BAO/PCP.php:850 [16] => CRM/PCP/BAO/PCP.php:875 [17] => CRM/Utils/System/Soap.php:68 [18] => CRM/Contribute/BAO/Widget.php:47 ) ' echo '' echo 'Total number of edits to perform: 19' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/Import/Parser/Contact.php' 253 edit_at_line 'CRM/Contact/Import/Parser/Contact.php' 265 edit_at_line 'CRM/Contact/Import/Parser/Contact.php' 278 edit_at_line 'CRM/Contact/Import/Parser/Contact.php' 452 edit_at_line 'CRM/Price/BAO/PriceField.php' 639 edit_at_line 'CRM/Core/BAO/Mapping.php' 71 edit_at_line 'CRM/Core/BAO/Mapping.php' 207 edit_at_line 'CRM/Utils/Array.php' 443 edit_at_line 'CRM/Core/Permission/Base.php' 159 edit_at_line 'CRM/Core/Permission/Base.php' 173 edit_at_line 'CRM/Core/Payment.php' 592 edit_at_line 'CRM/Core/Payment/PayPalProIPN.php' 166 edit_at_line 'CRM/Core/Payment/PayPalProIPN.php' 392 edit_at_line 'CRM/PCP/BAO/PCP.php' 781 edit_at_line 'CRM/PCP/BAO/PCP.php' 800 edit_at_line 'CRM/PCP/BAO/PCP.php' 850 edit_at_line 'CRM/PCP/BAO/PCP.php' 875 edit_at_line 'CRM/Utils/System/Soap.php' 68 edit_at_line 'CRM/Contribute/BAO/Widget.php' 47 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.InvalidReturn!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines' echo 'Messages:Array ( [0] => Functions must not contain multiple empty lines in a row; found 2 empty lines ) ' echo 'Lines:Array ( [0] => CRM/Contact/Import/Parser/Contact.php:1016 [1] => CRM/Core/BAO/Mapping.php:1112 ) ' echo '' echo 'Total number of edits to perform: 2' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/Import/Parser/Contact.php' 1016 edit_at_line 'CRM/Core/BAO/Mapping.php' 1112 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.MissingParamName' echo 'Messages:Array ( [0] => Missing parameter name ) ' echo 'Lines:Array ( [0] => CRM/Custom/Form/Field.php:87 [1] => CRM/Custom/Form/Field.php:174 [2] => CRM/Custom/Form/Field.php:281 [3] => CRM/Custom/Form/Field.php:904 [4] => CRM/Core/BAO/LabelFormat.php:160 [5] => CRM/Core/BAO/LabelFormat.php:189 [6] => CRM/Core/BAO/LabelFormat.php:206 [7] => CRM/Core/BAO/LabelFormat.php:223 [8] => CRM/Core/BAO/LabelFormat.php:239 [9] => CRM/Core/BAO/LabelFormat.php:465 [10] => CRM/Price/Form/Set.php:51 [11] => CRM/Price/Form/Set.php:117 [12] => CRM/Price/Form/Set.php:241 [13] => CRM/Price/Form/Set.php:264 [14] => CRM/Utils/System/Soap.php:130 ) ' echo '' echo 'Total number of edits to perform: 15' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Custom/Form/Field.php' 87 edit_at_line 'CRM/Custom/Form/Field.php' 174 edit_at_line 'CRM/Custom/Form/Field.php' 281 edit_at_line 'CRM/Custom/Form/Field.php' 904 edit_at_line 'CRM/Core/BAO/LabelFormat.php' 160 edit_at_line 'CRM/Core/BAO/LabelFormat.php' 189 edit_at_line 'CRM/Core/BAO/LabelFormat.php' 206 edit_at_line 'CRM/Core/BAO/LabelFormat.php' 223 edit_at_line 'CRM/Core/BAO/LabelFormat.php' 239 edit_at_line 'CRM/Core/BAO/LabelFormat.php' 465 edit_at_line 'CRM/Price/Form/Set.php' 51 edit_at_line 'CRM/Price/Form/Set.php' 117 edit_at_line 'CRM/Price/Form/Set.php' 241 edit_at_line 'CRM/Price/Form/Set.php' 264 edit_at_line 'CRM/Utils/System/Soap.php' 130 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.MissingParamName!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.PHP.NonExecutableCode.ReturnNotRequired' echo 'Messages:Array ( [0] => Empty return statement not required here ) ' echo 'Lines:Array ( [0] => CRM/Price/BAO/PriceField.php:204 [1] => CRM/Utils/System/Soap.php:59 [2] => CRM/Utils/System/Soap.php:84 [3] => CRM/Utils/System/Soap.php:96 ) ' echo '' echo 'Total number of edits to perform: 4' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Price/BAO/PriceField.php' 204 edit_at_line 'CRM/Utils/System/Soap.php' 59 edit_at_line 'CRM/Utils/System/Soap.php' 84 edit_at_line 'CRM/Utils/System/Soap.php' 96 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.PHP.NonExecutableCode.ReturnNotRequired!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.WhiteSpace.OpenBracketSpacing.OpeningWhitespace' echo 'Messages:Array ( [0] => There should be no white space after an opening \"{\" ) ' echo 'Lines:Array ( [0] => CRM/Price/BAO/PriceField.php:329 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Price/BAO/PriceField.php' 329 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.WhiteSpace.OpenBracketSpacing.OpeningWhitespace!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.SpacingAfter' echo 'Messages:Array ( [0] => There must be no blank lines after the function comment ) ' echo 'Lines:Array ( [0] => CRM/Price/BAO/PriceField.php:690 [1] => CRM/Core/Permission/Base.php:161 [2] => CRM/Core/Permission/Base.php:175 [3] => CRM/Core/Page/Basic.php:47 ) ' echo '' echo 'Total number of edits to perform: 4' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Price/BAO/PriceField.php' 690 edit_at_line 'CRM/Core/Permission/Base.php' 161 edit_at_line 'CRM/Core/Permission/Base.php' 175 edit_at_line 'CRM/Core/Page/Basic.php' 47 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.SpacingAfter!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.InvalidReturnNotVoid' echo 'Messages:Array ( [0] => Function return type is not void, but function is returning void here ) ' echo 'Lines:Array ( [0] => CRM/Core/BAO/Mapping.php:1193 [1] => CRM/Event/Form/Registration.php:835 [2] => CRM/Core/Payment/PayPalProIPN.php:399 [3] => CRM/Report/Form/Extended.php:1225 [4] => CRM/Report/Form/Extended.php:1377 [5] => CRM/Report/Form/Extended.php:1389 ) ' echo '' echo 'Total number of edits to perform: 6' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Core/BAO/Mapping.php' 1193 edit_at_line 'CRM/Event/Form/Registration.php' 835 edit_at_line 'CRM/Core/Payment/PayPalProIPN.php' 399 edit_at_line 'CRM/Report/Form/Extended.php' 1225 edit_at_line 'CRM/Report/Form/Extended.php' 1377 edit_at_line 'CRM/Report/Form/Extended.php' 1389 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.InvalidReturnNotVoid!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Classes.ClassCreateInstance' echo 'Messages:Array ( [0] => Calling class constructors must always include parentheses ) ' echo 'Lines:Array ( [0] => CRM/Upgrade/Incremental/php/FourTwo.php:191 [1] => CRM/Upgrade/Incremental/php/FourTwo.php:288 [2] => CRM/Upgrade/Incremental/php/ThreeTwo.php:98 [3] => CRM/Upgrade/Incremental/php/ThreeTwo.php:108 [4] => CRM/Upgrade/Incremental/php/ThreeTwo.php:226 [5] => CRM/Upgrade/Incremental/php/ThreeTwo.php:287 [6] => CRM/Upgrade/Incremental/php/FourOne.php:337 ) ' echo '' echo 'Total number of edits to perform: 7' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Upgrade/Incremental/php/FourTwo.php' 191 edit_at_line 'CRM/Upgrade/Incremental/php/FourTwo.php' 288 edit_at_line 'CRM/Upgrade/Incremental/php/ThreeTwo.php' 98 edit_at_line 'CRM/Upgrade/Incremental/php/ThreeTwo.php' 108 edit_at_line 'CRM/Upgrade/Incremental/php/ThreeTwo.php' 226 edit_at_line 'CRM/Upgrade/Incremental/php/ThreeTwo.php' 287 edit_at_line 'CRM/Upgrade/Incremental/php/FourOne.php' 337 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Classes.ClassCreateInstance!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.DocComment.WrongEnd' echo 'Messages:Array ( [0] => Wrong function doc comment end; expected \"*/\", found \"**/\" ) ' echo 'Lines:Array ( [0] => CRM/Core/Payment/FirstData.php:32 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Core/Payment/FirstData.php' 32 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.DocComment.WrongEnd!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.WrongStyle' echo 'Messages:Array ( [0] => You must use \"/**\" style comments for a function comment ) ' echo 'Lines:Array ( [0] => CRM/Core/Payment/FirstData.php:76 [1] => CRM/Core/Payment/FirstData.php:88 [2] => CRM/Core/Payment/FirstData.php:146 [3] => CRM/Core/Payment/FirstData.php:321 [4] => CRM/Core/Payment/FirstData.php:336 [5] => CRM/Core/Payment/FirstData.php:355 [6] => tests/phpunit/WebTest/Event/AddParticipationTest.php:377 [7] => CRM/Upgrade/Incremental/php/FourFour.php:794 ) ' echo '' echo 'Total number of edits to perform: 8' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Core/Payment/FirstData.php' 76 edit_at_line 'CRM/Core/Payment/FirstData.php' 88 edit_at_line 'CRM/Core/Payment/FirstData.php' 146 edit_at_line 'CRM/Core/Payment/FirstData.php' 321 edit_at_line 'CRM/Core/Payment/FirstData.php' 336 edit_at_line 'CRM/Core/Payment/FirstData.php' 355 edit_at_line 'tests/phpunit/WebTest/Event/AddParticipationTest.php' 377 edit_at_line 'CRM/Upgrade/Incremental/php/FourFour.php' 794 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.WrongStyle!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.ParamNameNoMatch' echo 'Messages:Array ( [0] => Doc comment for parameter $ctx does not match actual variable name $latestVer [1] => Doc comment for parameter $startId does not match actual variable name $latestVer [2] => Doc comment for parameter $endId does not match actual variable name $latestVer [3] => Doc comment for parameter $dayParamsArray does not match actual variable name $format ) ' echo 'Lines:Array ( [0] => CRM/Upgrade/Incremental/php/FourFour.php:360 [1] => CRM/Upgrade/Incremental/php/FourFour.php:361 [2] => CRM/Upgrade/Incremental/php/FourFour.php:362 [3] => CRM/Utils/Date.php:722 ) ' echo '' echo 'Total number of edits to perform: 4' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Upgrade/Incremental/php/FourFour.php' 360 edit_at_line 'CRM/Upgrade/Incremental/php/FourFour.php' 361 edit_at_line 'CRM/Upgrade/Incremental/php/FourFour.php' 362 edit_at_line 'CRM/Utils/Date.php' 722 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.ParamNameNoMatch!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Array.Array.ArrayIndentation' echo 'Messages:Array ( [0] => Array indentation error, expected 8 spaces but found 10 [1] => Array indentation error, expected 10 spaces but found 8 ) ' echo 'Lines:Array ( [0] => CRM/Report/Form/Extended.php:253 [1] => CRM/Report/Form/Extended.php:258 [2] => CRM/Report/Form/Extended.php:600 ) ' echo '' echo 'Total number of edits to perform: 3' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Report/Form/Extended.php' 253 edit_at_line 'CRM/Report/Form/Extended.php' 258 edit_at_line 'CRM/Report/Form/Extended.php' 600 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Array.Array.ArrayIndentation!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.WhiteSpace.OperatorSpacing.NoSpaceAfter' echo 'Messages:Array ( [0] => Expected 1 space after \"+\"; 0 found ) ' echo 'Lines:Array ( [0] => CRM/Utils/Date.php:1440 [1] => CRM/Utils/Date.php:1540 [2] => CRM/Utils/Date.php:1549 [3] => CRM/Utils/Date.php:1609 ) ' echo '' echo 'Total number of edits to perform: 4' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Utils/Date.php' 1440 edit_at_line 'CRM/Utils/Date.php' 1540 edit_at_line 'CRM/Utils/Date.php' 1549 edit_at_line 'CRM/Utils/Date.php' 1609 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.WhiteSpace.OperatorSpacing.NoSpaceAfter!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Files.EndFileNewline.TooMany' echo 'Messages:Array ( [0] => Expected 1 newline at end of file; 2 found ) ' echo 'Lines:Array ( [0] => CRM/Contribute/Selector/Search.php:573 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contribute/Selector/Search.php' 573 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Files.EndFileNewline.TooMany!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.IncorrectParamVarName' echo 'Messages:Array ( [0] => Expected \"int\" but found \"number\" for parameter type ) ' echo 'Lines:Array ( [0] => CRM/Core/BAO/FinancialTrxn.php:419 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Core/BAO/FinancialTrxn.php' 419 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.IncorrectParamVarName!' echo '' echo 'Yay!' echo '' fi