#!/bin/bash ## usage: bash batch-0.sh.txt #[ -n "$1" ] && EDITOR="$1" #if [ -z "$EDITOR" ]; then # echo "Please provide parameter 1 (editor). Example: vi, joe" # exit 1 #fi function edit_at_line() { local f="$1" local l="$2" $EDITOR +$l "$f" } function ask_continue() { local line="" while [ "$line" != "y" -a "$line" != "n" ]; do echo -n "$1 (Y/n) " read line if [ -z "$line" ]; then line=y fi done if [ "$line" == "y" ]; then return 0 else return 1 fi } echo 'Welcome and thanks for helping with the cleanup!' echo '' echo 'This script will walk through a series of code-style issues in Civi'\''s PHP code.' echo 'For each issue, it will show a summary of the issue (ie how many files are' echo 'affected, how many lines of code are affected, and what detailed messages' echo 'are available about the issues.' echo '' echo 'The script will open the first file at the offending line so that you can fix' echo 'it. Please save, edit, close. The script will then repeat -- re-opening the text' echo 'editor at each offending line.' echo '' echo 'The script should generally open on the exact line with the problem; however,' echo 'if other changes were recently made to the file, then the line numbers may be' echo 'slightly off - if you don'\''t see a problem, then check the neighboring lines.' ask_continue 'Continue?' || exit echo '' echo 'What text editor would you prefer to use? [vi, emacs, joe]?' read EDITOR echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.WrongStyle' echo 'Messages:Array ( [0] => You must use \"/**\" style comments for a function comment ) ' echo 'Lines:Array ( [0] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:41 [1] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:67 ) ' echo '' echo 'Total number of edits to perform: 2' if ask_continue 'Edit these files?'; then edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 41 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 67 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.WrongStyle!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.Scope.MethodScope.Missing' echo 'Messages:Array ( [0] => Visibility must be declared on method \"_checkOpenedPanes\" [1] => Visibility must be declared on method \"_selectPaneFields\" [2] => Visibility must be declared on method \"__construct\" [3] => Visibility must be declared on method \"convertFormValues\" [4] => Visibility must be declared on method \"fixWhereValues\" [5] => Visibility must be declared on method \"apiQuery\" [6] => Visibility must be declared on method \"searchQuery\" [7] => Visibility must be declared on method \"dateQueryBuilder\" [8] => Visibility must be declared on method \"numberRangeBuilder\" [9] => Visibility must be declared on method \"optionValueQuery\" [10] => Visibility must be declared on method \"buildQillForFieldValue\" [11] => Visibility must be declared on method \"sendEmail\" [12] => Visibility must be declared on method \"sendSMS\" [13] => Visibility must be declared on method \"sendSMSMessage\" [14] => Visibility must be declared on method \"sendMessage\" [15] => Visibility must be declared on method \"addActivity\" [16] => Visibility must be declared on method \"all\" [17] => Visibility must be declared on method \"getStatistics\" ) ' echo 'Lines:Array ( [0] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:92 [1] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:114 [2] => CRM/Contact/BAO/Query.php:412 [3] => CRM/Contact/BAO/Query.php:1440 [4] => CRM/Contact/BAO/Query.php:1510 [5] => CRM/Contact/BAO/Query.php:4345 [6] => CRM/Contact/BAO/Query.php:4451 [7] => CRM/Contact/BAO/Query.php:4947 [8] => CRM/Contact/BAO/Query.php:5060 [9] => CRM/Contact/BAO/Query.php:5390 [10] => CRM/Contact/BAO/Query.php:5636 [11] => CRM/Activity/BAO/Activity.php:1179 [12] => CRM/Activity/BAO/Activity.php:1373 [13] => CRM/Activity/BAO/Activity.php:1511 [14] => CRM/Activity/BAO/Activity.php:1594 [15] => CRM/Activity/BAO/Activity.php:1796 [16] => CRM/Contact/Form/Search/Custom/PostalMailing.php:78 [17] => CRM/Report/Form/Grant/Statistics.php:533 ) ' echo '' echo 'Total number of edits to perform: 18' if ask_continue 'Edit these files?'; then edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 92 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 114 edit_at_line 'CRM/Contact/BAO/Query.php' 412 edit_at_line 'CRM/Contact/BAO/Query.php' 1440 edit_at_line 'CRM/Contact/BAO/Query.php' 1510 edit_at_line 'CRM/Contact/BAO/Query.php' 4345 edit_at_line 'CRM/Contact/BAO/Query.php' 4451 edit_at_line 'CRM/Contact/BAO/Query.php' 4947 edit_at_line 'CRM/Contact/BAO/Query.php' 5060 edit_at_line 'CRM/Contact/BAO/Query.php' 5390 edit_at_line 'CRM/Contact/BAO/Query.php' 5636 edit_at_line 'CRM/Activity/BAO/Activity.php' 1179 edit_at_line 'CRM/Activity/BAO/Activity.php' 1373 edit_at_line 'CRM/Activity/BAO/Activity.php' 1511 edit_at_line 'CRM/Activity/BAO/Activity.php' 1594 edit_at_line 'CRM/Activity/BAO/Activity.php' 1796 edit_at_line 'CRM/Contact/Form/Search/Custom/PostalMailing.php' 78 edit_at_line 'CRM/Report/Form/Grant/Statistics.php' 533 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.Scope.MethodScope.Missing!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Array.Array.ArrayIndentation' echo 'Messages:Array ( [0] => Array indentation error, expected 8 spaces but found 10 [1] => Array indentation error, expected 12 spaces but found 14 [2] => Array indentation error, expected 16 spaces but found 18 ) ' echo 'Lines:Array ( [0] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:177 [1] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:182 [2] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:184 [3] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:188 [4] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:190 [5] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:194 [6] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:196 [7] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:200 [8] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:201 [9] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:202 [10] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:204 [11] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:209 [12] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:211 [13] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:215 [14] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:216 [15] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:217 [16] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:219 [17] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:224 [18] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:226 [19] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:234 [20] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:236 [21] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:240 [22] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:242 [23] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:245 [24] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:246 [25] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:247 [26] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:249 [27] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:254 [28] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:256 [29] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:260 [30] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:262 [31] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:266 [32] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:267 [33] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:268 [34] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:270 [35] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:275 [36] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:277 [37] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:281 [38] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:283 [39] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:287 [40] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:289 [41] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:293 [42] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:294 [43] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:295 [44] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:297 [45] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:302 [46] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:304 [47] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:308 [48] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:309 [49] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:310 [50] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:312 [51] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:317 [52] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:319 [53] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:323 [54] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:324 [55] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:325 [56] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:327 [57] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:332 [58] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:334 [59] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:338 [60] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:340 [61] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:344 [62] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:347 [63] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:351 [64] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:353 [65] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:356 [66] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:357 [67] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:358 [68] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:360 [69] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:365 [70] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:367 [71] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:370 [72] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:372 [73] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:375 [74] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:376 [75] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:377 [76] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:379 [77] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:384 [78] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:386 [79] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:389 [80] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:391 [81] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:394 [82] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:395 [83] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:396 [84] => CRM/Contact/BAO/Query.php:4891 [85] => CRM/Contact/BAO/Query.php:4933 ) ' echo '' echo 'Total number of edits to perform: 86' if ask_continue 'Edit these files?'; then edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 177 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 182 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 184 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 188 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 190 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 194 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 196 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 200 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 201 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 202 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 204 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 209 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 211 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 215 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 216 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 217 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 219 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 224 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 226 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 234 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 236 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 240 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 242 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 245 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 246 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 247 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 249 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 254 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 256 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 260 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 262 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 266 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 267 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 268 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 270 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 275 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 277 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 281 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 283 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 287 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 289 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 293 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 294 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 295 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 297 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 302 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 304 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 308 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 309 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 310 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 312 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 317 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 319 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 323 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 324 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 325 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 327 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 332 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 334 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 338 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 340 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 344 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 347 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 351 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 353 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 356 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 357 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 358 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 360 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 365 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 367 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 370 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 372 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 375 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 376 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 377 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 379 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 384 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 386 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 389 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 391 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 394 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 395 edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 396 edit_at_line 'CRM/Contact/BAO/Query.php' 4891 edit_at_line 'CRM/Contact/BAO/Query.php' 4933 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Array.Array.ArrayIndentation!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Array.Array' echo 'Messages:Array ( [0] => A comma should follow the last multiline array item. Found: '\''activity_type_id[7]'\'' [1] => A comma should follow the last multiline array item. Found: start_date ) ' echo 'Lines:Array ( [0] => tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php:232 [1] => CRM/Event/Cart/Form/Checkout/ParticipantsAndPrices.php:149 ) ' echo '' echo 'Total number of edits to perform: 2' if ask_continue 'Edit these files?'; then edit_at_line 'tests/phpunit/WebTest/Contact/AdvanceSearchPaneTest.php' 232 edit_at_line 'CRM/Event/Cart/Form/Checkout/ParticipantsAndPrices.php' 149 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Array.Array!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Formatting.MultiLineAssignment' echo 'Messages:Array ( [0] => Multi-line assignments must have the equal sign on the second line ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Query.php:691 [1] => CRM/Contact/BAO/Query.php:697 [2] => CRM/Contact/BAO/Query.php:703 [3] => CRM/Contact/BAO/Query.php:729 [4] => CRM/Contact/BAO/Query.php:738 [5] => CRM/Contact/BAO/Query.php:747 [6] => CRM/Contact/BAO/Query.php:1108 [7] => CRM/Contact/BAO/Query.php:1113 [8] => CRM/Contact/BAO/Query.php:1181 [9] => CRM/Contact/BAO/Query.php:1190 [10] => CRM/Contact/BAO/Query.php:1199 [11] => CRM/Contact/BAO/Query.php:2997 [12] => CRM/Contact/BAO/Query.php:2998 [13] => CRM/Contact/BAO/Query.php:3005 [14] => CRM/Contact/BAO/Query.php:3006 [15] => CRM/Contact/BAO/Query.php:3019 [16] => CRM/Contact/BAO/Query.php:3020 [17] => CRM/Contact/BAO/Query.php:3076 [18] => CRM/Contact/BAO/Query.php:3077 [19] => CRM/Contact/BAO/Query.php:3085 [20] => CRM/Contact/BAO/Query.php:3086 [21] => CRM/Contact/BAO/Query.php:3094 [22] => CRM/Contact/BAO/Query.php:3095 [23] => CRM/Contact/BAO/Query.php:3113 [24] => CRM/Contact/BAO/Query.php:3114 [25] => CRM/Contact/BAO/Query.php:3147 [26] => CRM/Contact/BAO/Query.php:3148 [27] => CRM/Contact/BAO/Query.php:4035 [28] => CRM/Contact/BAO/Query.php:4036 [29] => CRM/Contact/BAO/Query.php:4070 [30] => CRM/Contact/BAO/Query.php:4071 [31] => CRM/Contact/BAO/Query.php:4073 [32] => CRM/Contact/BAO/Query.php:5109 ) ' echo '' echo 'Total number of edits to perform: 33' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Query.php' 691 edit_at_line 'CRM/Contact/BAO/Query.php' 697 edit_at_line 'CRM/Contact/BAO/Query.php' 703 edit_at_line 'CRM/Contact/BAO/Query.php' 729 edit_at_line 'CRM/Contact/BAO/Query.php' 738 edit_at_line 'CRM/Contact/BAO/Query.php' 747 edit_at_line 'CRM/Contact/BAO/Query.php' 1108 edit_at_line 'CRM/Contact/BAO/Query.php' 1113 edit_at_line 'CRM/Contact/BAO/Query.php' 1181 edit_at_line 'CRM/Contact/BAO/Query.php' 1190 edit_at_line 'CRM/Contact/BAO/Query.php' 1199 edit_at_line 'CRM/Contact/BAO/Query.php' 2997 edit_at_line 'CRM/Contact/BAO/Query.php' 2998 edit_at_line 'CRM/Contact/BAO/Query.php' 3005 edit_at_line 'CRM/Contact/BAO/Query.php' 3006 edit_at_line 'CRM/Contact/BAO/Query.php' 3019 edit_at_line 'CRM/Contact/BAO/Query.php' 3020 edit_at_line 'CRM/Contact/BAO/Query.php' 3076 edit_at_line 'CRM/Contact/BAO/Query.php' 3077 edit_at_line 'CRM/Contact/BAO/Query.php' 3085 edit_at_line 'CRM/Contact/BAO/Query.php' 3086 edit_at_line 'CRM/Contact/BAO/Query.php' 3094 edit_at_line 'CRM/Contact/BAO/Query.php' 3095 edit_at_line 'CRM/Contact/BAO/Query.php' 3113 edit_at_line 'CRM/Contact/BAO/Query.php' 3114 edit_at_line 'CRM/Contact/BAO/Query.php' 3147 edit_at_line 'CRM/Contact/BAO/Query.php' 3148 edit_at_line 'CRM/Contact/BAO/Query.php' 4035 edit_at_line 'CRM/Contact/BAO/Query.php' 4036 edit_at_line 'CRM/Contact/BAO/Query.php' 4070 edit_at_line 'CRM/Contact/BAO/Query.php' 4071 edit_at_line 'CRM/Contact/BAO/Query.php' 4073 edit_at_line 'CRM/Contact/BAO/Query.php' 5109 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Formatting.MultiLineAssignment!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines' echo 'Messages:Array ( [0] => Functions must not contain multiple empty lines in a row; found 2 empty lines ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Query.php:1011 [1] => CRM/Contact/BAO/Query.php:2988 [2] => CRM/Contact/BAO/Query.php:3068 [3] => CRM/Contact/BAO/Query.php:3843 [4] => CRM/Contact/BAO/Query.php:4048 [5] => CRM/Contact/BAO/Query.php:4065 [6] => CRM/Contact/BAO/Query.php:4736 [7] => CRM/Activity/BAO/Activity.php:1054 [8] => CRM/Activity/BAO/Activity.php:1275 [9] => CRM/Activity/BAO/Activity.php:1558 [10] => CRM/Activity/BAO/Activity.php:1726 [11] => CRM/Activity/BAO/Activity.php:2167 [12] => CRM/Core/BAO/Preferences.php:132 ) ' echo '' echo 'Total number of edits to perform: 13' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Query.php' 1011 edit_at_line 'CRM/Contact/BAO/Query.php' 2988 edit_at_line 'CRM/Contact/BAO/Query.php' 3068 edit_at_line 'CRM/Contact/BAO/Query.php' 3843 edit_at_line 'CRM/Contact/BAO/Query.php' 4048 edit_at_line 'CRM/Contact/BAO/Query.php' 4065 edit_at_line 'CRM/Contact/BAO/Query.php' 4736 edit_at_line 'CRM/Activity/BAO/Activity.php' 1054 edit_at_line 'CRM/Activity/BAO/Activity.php' 1275 edit_at_line 'CRM/Activity/BAO/Activity.php' 1558 edit_at_line 'CRM/Activity/BAO/Activity.php' 1726 edit_at_line 'CRM/Activity/BAO/Activity.php' 2167 edit_at_line 'CRM/Core/BAO/Preferences.php' 132 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.InvalidReturnNotVoid' echo 'Messages:Array ( [0] => Function return type is not void, but function is returning void here ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Query.php:3568 [1] => CRM/Contact/BAO/Query.php:5518 [2] => CRM/Contact/BAO/Query.php:5593 [3] => CRM/Activity/BAO/Activity.php:1852 [4] => CRM/Activity/BAO/Activity.php:2065 ) ' echo '' echo 'Total number of edits to perform: 5' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Query.php' 3568 edit_at_line 'CRM/Contact/BAO/Query.php' 5518 edit_at_line 'CRM/Contact/BAO/Query.php' 5593 edit_at_line 'CRM/Activity/BAO/Activity.php' 1852 edit_at_line 'CRM/Activity/BAO/Activity.php' 2065 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.InvalidReturnNotVoid!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.InvalidNoReturn' echo 'Messages:Array ( [0] => @return doc comment specified, but function has no return statement ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Query.php:4665 [1] => CRM/Activity/BAO/Activity.php:253 ) ' echo '' echo 'Total number of edits to perform: 2' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Query.php' 4665 edit_at_line 'CRM/Activity/BAO/Activity.php' 253 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.InvalidNoReturn!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.PHP.NonExecutableCode.ReturnNotRequired' echo 'Messages:Array ( [0] => Empty return statement not required here ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Query.php:5133 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Query.php' 5133 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.PHP.NonExecutableCode.ReturnNotRequired!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.MissingParamName' echo 'Messages:Array ( [0] => Missing parameter name ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Query.php:5511 [1] => CRM/Core/BAO/LocationType.php:90 ) ' echo '' echo 'Total number of edits to perform: 2' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Query.php' 5511 edit_at_line 'CRM/Core/BAO/LocationType.php' 90 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.MissingParamName!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Generic.Formatting.SpaceAfterCast.NoSpace' echo 'Messages:Array ( [0] => A cast statement must be followed by a single space ) ' echo 'Lines:Array ( [0] => CRM/Contact/BAO/Query.php:5659 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Contact/BAO/Query.php' 5659 echo '===============================================================' echo '' echo 'Completed formatting issue Generic.Formatting.SpaceAfterCast.NoSpace!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.InvalidReturn' echo 'Messages:Array ( [0] => Expected \"bool\" but found \"boolean\" for function return type ) ' echo 'Lines:Array ( [0] => CRM/Activity/BAO/Activity.php:62 [1] => CRM/Activity/BAO/Activity.php:1591 [2] => CRM/Activity/BAO/Activity.php:2300 ) ' echo '' echo 'Total number of edits to perform: 3' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Activity/BAO/Activity.php' 62 edit_at_line 'CRM/Activity/BAO/Activity.php' 1591 edit_at_line 'CRM/Activity/BAO/Activity.php' 2300 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.InvalidReturn!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.$InReturnType' echo 'Messages:Array ( [0] => @return data type must not contain \"$\" ) ' echo 'Lines:Array ( [0] => CRM/Activity/BAO/Activity.php:272 [1] => CRM/Activity/BAO/Activity.php:2061 ) ' echo '' echo 'Total number of edits to perform: 2' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Activity/BAO/Activity.php' 272 edit_at_line 'CRM/Activity/BAO/Activity.php' 2061 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.$InReturnType!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.DocComment.WrongEnd' echo 'Messages:Array ( [0] => Wrong function doc comment end; expected \"*/\", found \"**/\" ) ' echo 'Lines:Array ( [0] => CRM/Activity/BAO/Activity.php:908 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Activity/BAO/Activity.php' 908 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.DocComment.WrongEnd!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint' echo 'Messages:Array ( [0] => Expected 1 space between type hint and argument \"$additionalDetails\"; 4 found ) ' echo 'Lines:Array ( [0] => CRM/Activity/BAO/Activity.php:1190 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Activity/BAO/Activity.php' 1190 echo '===============================================================' echo '' echo 'Completed formatting issue Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.WhiteSpace.OpenBracketSpacing.OpeningWhitespace' echo 'Messages:Array ( [0] => There should be no white space after an opening \"{\" ) ' echo 'Lines:Array ( [0] => CRM/Activity/BAO/Activity.php:2615 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Activity/BAO/Activity.php' 2615 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.WhiteSpace.OpenBracketSpacing.OpeningWhitespace!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.ParamNameNoMatch' echo 'Messages:Array ( [0] => Doc comment for parameter $from does not match actual variable name $table ) ' echo 'Lines:Array ( [0] => CRM/Utils/SQL/Insert.php:56 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'CRM/Utils/SQL/Insert.php' 56 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.ParamNameNoMatch!' echo '' echo 'Yay!' echo '' fi echo '===============================================================' echo 'Formatting issue: Drupal.Commenting.FunctionComment.ReturnCommentIndentation' echo 'Messages:Array ( [0] => Return comment indentation must be 3 spaces, found 1 spaces ) ' echo 'Lines:Array ( [0] => api/v3/OptionGroup.php:55 ) ' echo '' echo 'Total number of edits to perform: 1' if ask_continue 'Edit these files?'; then edit_at_line 'api/v3/OptionGroup.php' 55 echo '===============================================================' echo '' echo 'Completed formatting issue Drupal.Commenting.FunctionComment.ReturnCommentIndentation!' echo '' echo 'Yay!' echo '' fi